ci: drop FranzDiebold/github-env-vars-action #9641#16
Open
Ayesh wants to merge 1 commit intolinkorb:masterfrom
Open
ci: drop FranzDiebold/github-env-vars-action #9641#16Ayesh wants to merge 1 commit intolinkorb:masterfrom
Ayesh wants to merge 1 commit intolinkorb:masterfrom
Conversation
Ayesh
force-pushed
the
fix/9641-github-envvars
branch
2 times, most recently
from
977407a to
b116fe0
Compare
5 tasks
Ayesh
force-pushed
the
fix/9641-github-envvars
branch
from
b116fe0 to
2554bef
Compare
This drops the `FranzDiebold/github-env-vars-action` in favor of native
GH-Actions replacement patterns available.
ghcr.io (and other container registries for that matter) do not allow
mix-case image names, so when a the repo is forked by a user with a
mixed case username, or when reused in a repo with a mixed case repo
name, the Docker image tagging step fails.
When a lowercase username is needed it is now dynamically bash-eval'd
directly in the called line.
Notable replacements:
- `${{ env.CI_REPOSITORY_OWNER_SLUG }}`: `$(echo '${{ github.repository }}' | tr '[:upper:]' '[:lower:]')`
- `${{ env.CI_REPOSITORY_NAME }}`: `${{ github.event.repository.name }}`
Related: [#9639](http://team.linkorb.com/cards/9639).
Ayesh
force-pushed
the
fix/9641-github-envvars
branch
from
2554bef to
0e09641
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops the
FranzDiebold/github-env-vars-actionin favor of native GH-Actions replacement patterns available.ghcr.io (and other container registries for that matter) do not allow mix-case image names, so when a the repo is forked by a user with a mixed case username, or when reused in a repo with a mixed case repo name, the Docker image tagging step fails.
When a lowercase username is needed it is now dynamically bash-eval'd directly in the called line.
Notable replacements:
${{ env.CI_REPOSITORY_OWNER_SLUG }}:$(echo '${{ github.repository }}' | tr '[:upper:]' '[:lower:]')${{ env.CI_REPOSITORY_NAME }}:${{ github.event.repository.name }}Related: #9639.
Proposed changes
Checklist